Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ignition-transport #324

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Migrate ignition-transport #324

merged 1 commit into from
Jun 26, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon
Migrate ignition-transport
b49a545 
Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 26, 2022
@methylDragon methylDragon mentioned this pull request Jun 26, 2022
Closed
17 tasks
@codecov
Copy link

codecov bot commented Jun 26, 2022 •
edited
Loading

Codecov Report

Merging #324 (b49a545) into main (f0ebc57) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   88.32%   88.37%   +0.04%     
==========================================
  Files          52       52              
  Lines        4850     4850              
==========================================
+ Hits         4284     4286       +2     
+ Misses        566      564       -2
Impacted Files Coverage Δ
include/gz/transport/ReqHandler.hh 80.58% <ø> (ø)
src/cmd/gz.cc 95.31% <ø> (ø)
src/cmd/service_main.cc 96.00% <ø> (ø)
src/cmd/topic_main.cc 95.00% <ø> (ø)
log/src/Log.cc 77.97% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e4c7a...b49a545. Read the comment docs.

chapulina
chapulina approved these changes Jun 26, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@chapulina chapulina merged commit 5b579b7 into main Jun 26, 2022
@chapulina chapulina deleted the migrate_ignition_transport branch June 26, 2022 04:14
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina